Fix rate limit issue on raw reaction add/remove events.#3306
Merged
Taaku18 merged 3 commits intomodmail-dev:developmentfrom Nov 19, 2023
Merged
Fix rate limit issue on raw reaction add/remove events.#3306Taaku18 merged 3 commits intomodmail-dev:developmentfrom
Taaku18 merged 3 commits intomodmail-dev:developmentfrom
Conversation
Taaku18
approved these changes
Nov 19, 2023
Collaborator
Taaku18
left a comment
Taaku18
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR.
Merged
raidensakura
pushed a commit
to raidensakura/modmail
that referenced
this pull request
Apr 10, 2024
…3306) * Fix rate limit issue on raw reaction add/remove events. * Pasd message object to `find_linked_messages` since it is already fetched. --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Jun 18, 2024
…3306) * Fix rate limit issue on raw reaction add/remove events. * Pasd message object to `find_linked_messages` since it is already fetched. --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> (cherry picked from commit ae99060) Signed-off-by: Khakers <22665282+khakers@users.noreply.github.com>
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Jun 18, 2024
…3306) * Fix rate limit issue on raw reaction add/remove events. * Pasd message object to `find_linked_messages` since it is already fetched. --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> (cherry picked from commit ae99060) Signed-off-by: Khakers <22665282+khakers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rate limit on reaction events issue has been reported multiple times in support server. The latest one (as of this PR is created) can be found here.
Currently the bot attempts to fetch the message using API call on every reaction made including in other than thread channels. It is quite unnecessary since we only need the message object to do thread stuff (mostly linking messages). More explanation of the issue can be found in support server's help channel here.
This PR fixes the issue by making sure the thread exists before using API call to fetch the message.