Set smaller size for guild icons urls on embed icons#3261
Merged
Taaku18 merged 6 commits intomodmail-dev:developmentfrom Jul 15, 2023
baptiste0928:feat/guild-icon-size
Merged
Set smaller size for guild icons urls on embed icons#3261Taaku18 merged 6 commits intomodmail-dev:developmentfrom baptiste0928:feat/guild-icon-size
Taaku18 merged 6 commits intomodmail-dev:developmentfrom
baptiste0928:feat/guild-icon-size
Conversation
Member
|
You'll want to aim this PR at the development branch and not the main branch |
Contributor
Author
Rebased onto |
Signed-off-by: Taku <45324516+Taaku18@users.noreply.github.com>
Taaku18
approved these changes
Jul 12, 2023
Collaborator
Taaku18
left a comment
Taaku18
left a comment
There was a problem hiding this comment.
Everything looks good! Thanks for the PR, will be merged for the next update.
Perhaps in the future, it would be nice to update all the user/bot avatar URLs that are part of the author and footer as well.
Merged
raidensakura
pushed a commit
to raidensakura/modmail
that referenced
this pull request
Apr 10, 2024
* Set size for guild icons on embeds * Update changelog * Format with black * Fixed incorrect function return type --------- Signed-off-by: Taku <45324516+Taaku18@users.noreply.github.com> Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guild icon is used in full size on embed footers or the author icon for some messages. This can cause lag on the mobile app if the icon is animated.
This PR introduces a new optional
sizeargument toget_guild_iconand sets the size to 128 when it's used for embed footers or author icons (I chose a conservative value, 64 should render nicely even on higher DPI).