logs id command#3196
Merged
Taaku18 merged 11 commits intodevelopmentfrom Jul 15, 2023
unknown repository
Merged
Conversation
added 3 commits
September 9, 2022 22:48
ghost
changed the base branch from
Taaku18
requested changes
Mar 14, 2023
Collaborator
Taaku18
left a comment
Taaku18
left a comment
There was a problem hiding this comment.
Thanks for the PR. Summarizing from my comments: I prefer if you rename the command from logs id -> logs key, and remove the open check from L1225 to L1232.
Author
|
Have completed the requested changes. A closed log will show this While if a log is open it will show this Can see here it is a commented known bug |
Taaku18
requested changes
Mar 14, 2023
Collaborator
Taaku18
left a comment
Taaku18
left a comment
There was a problem hiding this comment.
Everything else looks great, thanks for the changes.
Taaku18
previously approved these changes
Jul 11, 2023
Merged
raidensakura
pushed a commit
to raidensakura/modmail
that referenced
this pull request
Apr 10, 2024
* Update modmail.py * Update clients.py * Formatting * Change log id to log key, added id as an alias * Print the log even if it is closed and fix bug * Update modmail.py * Added a missing period * Updated changelog --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Jun 18, 2024
* Update modmail.py * Update clients.py * Formatting * Change log id to log key, added id as an alias * Print the log even if it is closed and fix bug * Update modmail.py * Added a missing period * Updated changelog --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> (cherry picked from commit b1f3645) Signed-off-by: Khakers <22665282+khakers@users.noreply.github.com>
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Jun 18, 2024
* Update modmail.py * Update clients.py * Formatting * Change log id to log key, added id as an alias * Print the log even if it is closed and fix bug * Update modmail.py * Added a missing period * Updated changelog --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> (cherry picked from commit b1f3645) Signed-off-by: Khakers <22665282+khakers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added command
logs id <key>, this helps users locate the log link / preview if they just have the log id.This will help once a Heroku alternative is found and users log link changes due to moving from Heroku. They can use this command to bring up the new link easily
Have tested this.
Remade the PR because I changed the branch