feat(mve): add support for gwe-gwe exchanges that include mve package#2750
Merged
wpbonelli merged 1 commit intomodflowpy:developfrom Apr 22, 2026
Merged
feat(mve): add support for gwe-gwe exchanges that include mve package#2750wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli merged 1 commit intomodflowpy:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2750 +/- ##
===========================================
+ Coverage 55.5% 72.4% +16.8%
===========================================
Files 644 675 +31
Lines 124135 132046 +7911
===========================================
+ Hits 68947 95632 +26685
+ Misses 55188 36414 -18774
🚀 New features to boost your workflow:
|
4 tasks
wpbonelli
approved these changes
Apr 22, 2026
Member
wpbonelli
left a comment
There was a problem hiding this comment.
Looks good to me. I know it's not ideal to have to do this manually but it's temporary. In 4.x mfstructure.py will go away, and we can hopefully drop the special casing in the new code generation logic too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model-level
MVEpackage was previously supported by virtue of the dfn file. However, simulation-level support forMVEwas not supported. A new autotest for MF6 confirms that these changes are sufficient.This missing functionality was discovered when attempting to support parallel energy mover (
MVE) transport in MF6. For example, if a stream was split across two flow and transport models and a transport mover was required to properly route solute from an SFT reach in one model to a connected SFT reach in a downstream model, MVT worked, but its complement in GWE, namely MVE, was not working prior to this PR.