Skip to content

feat(mve): add support for gwe-gwe exchanges that include mve package#2750

Merged
wpbonelli merged 1 commit intomodflowpy:developfrom
emorway-usgs:mve_support
Apr 22, 2026
Merged

feat(mve): add support for gwe-gwe exchanges that include mve package#2750
wpbonelli merged 1 commit intomodflowpy:developfrom
emorway-usgs:mve_support

Conversation

@emorway-usgs
Copy link
Copy Markdown
Contributor

@emorway-usgs emorway-usgs commented Apr 21, 2026

model-level MVE package was previously supported by virtue of the dfn file. However, simulation-level support for MVE was not supported. A new autotest for MF6 confirms that these changes are sufficient.

This missing functionality was discovered when attempting to support parallel energy mover (MVE) transport in MF6. For example, if a stream was split across two flow and transport models and a transport mover was required to properly route solute from an SFT reach in one model to a connected SFT reach in a downstream model, MVT worked, but its complement in GWE, namely MVE, was not working prior to this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.4%. Comparing base (556c088) to head (a692612).
⚠️ Report is 153 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/utils/codegen/filters.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2750      +/-   ##
===========================================
+ Coverage     55.5%    72.4%   +16.8%     
===========================================
  Files          644      675      +31     
  Lines       124135   132046    +7911     
===========================================
+ Hits         68947    95632   +26685     
+ Misses       55188    36414   -18774     
Files with missing lines Coverage Δ
flopy/mf6/data/mfstructure.py 74.1% <100.0%> (+0.4%) ⬆️
flopy/mf6/utils/codegen/component.py 0.0% <ø> (ø)
flopy/mf6/utils/codegen/filters.py 0.0% <0.0%> (ø)

... and 572 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I know it's not ideal to have to do this manually but it's temporary. In 4.x mfstructure.py will go away, and we can hopefully drop the special casing in the new code generation logic too.

@wpbonelli wpbonelli merged commit 71c82d8 into modflowpy:develop Apr 22, 2026
20 checks passed
@emorway-usgs emorway-usgs deleted the mve_support branch April 22, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants