feat: support mf6 binary output file conversion#2746
Open
wpbonelli wants to merge 10 commits intomodflowpy:developfrom
Open
feat: support mf6 binary output file conversion#2746wpbonelli wants to merge 10 commits intomodflowpy:developfrom
wpbonelli wants to merge 10 commits intomodflowpy:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2746 +/- ##
===========================================
+ Coverage 55.5% 72.5% +16.9%
===========================================
Files 644 676 +32
Lines 124135 132800 +8665
===========================================
+ Hits 68947 96312 +27365
+ Misses 55188 36488 -18700
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classic MODFLOW programs (NWT, MF2005, MF2000) produce binary output files that MF6 post-processors (e.g. PRT) cannot directly consume, because the budget format is fundamentally different and MF6 requires a binary grid file that classic programs do not write. Add conversion capability so classic program output can be converted to MF6 format and used with MF6 transport or particle-tracking models.
Introduce
ClassicMfToMf6Converterthat reads a classic compact head/budget file pair and writes three files.hds— copies verbatim.bud— converts FLOW RIGHT/FRONT/LOWER FACE → FLOW-JA-FACE + DATA-SAT.grb— creates binary grid file from DIS geometryThis builds on #2722 and required a few more utilities
get_icelltype_from_laytyp(): convert NWTLAYTYPto MF6ICELLTYPEget_icelltype_from_laycon(): convert BCFLAYCONto MF6ICELLTYPEget_saturation(): calculate saturation from head, cell geometry, cell typeget_structured_flowja(): inverse ofget_structured_faceflows()MfGrdFile.write_dis(): write grb file for structured gridUsage
Limitations