Skip to content

chore: improve prettier setup#3124

Merged
bashmish merged 1 commit into
masterfrom
chore/improve-prettier-setup
Jul 3, 2026
Merged

chore: improve prettier setup#3124
bashmish merged 1 commit into
masterfrom
chore/improve-prettier-setup

Conversation

@bashmish

@bashmish bashmish commented Jul 2, 2026

Copy link
Copy Markdown
Member

What I did

  1. upgrade prettier to latest
  2. make sure all embedded languages are formatted, especially js template literals used in tests
  3. make sure imports/exports are consistently ordered
    • there was an incorrect import leading to circular dependencies which I found when formatting imports/exports, so fixed that too
  4. exclude snapshots from formatting (also renamed some snapshots to follow same naming convention and apply same filter to exclude them)

@changeset-bot

changeset-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a4fd0c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish force-pushed the chore/improve-prettier-setup branch from 5bce5a3 to e799f2b Compare July 2, 2026 15:03
@thepassle

Copy link
Copy Markdown
Member

@bashmish some failing tests still

@bashmish bashmish force-pushed the chore/improve-prettier-setup branch from e799f2b to a4fd0c4 Compare July 3, 2026 13:12
@bashmish

bashmish commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

@thepassle I saw that

  • Node 22 passed
  • Node 24 is expected to fail, unrelated to this PR and we need to look into this separetely, we also discussed it yesterday
  • Windows passed (0 failures in logs), but the build is red, which happens sometimes and I couldn't find out why that happens (not related to this PR), sometimes I restart them and then it's green on the 2nd try, quite unstable in that regard

Not sure which tests you saw failing, but I'll proceed with merging for now.

@bashmish bashmish merged commit dcee2cc into master Jul 3, 2026
6 of 10 checks passed
@bashmish bashmish deleted the chore/improve-prettier-setup branch July 3, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants