Skip to content

refactor(dev-server-legacy): migrate tests to node:test #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashmish merged 4 commits into from
Jul 1, 2026
+25 −25
Merged

refactor(dev-server-legacy): migrate tests to node:test #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c847210
refactor(dev-server-legacy): migrate tests from mocha/chai to node:test
bennypowers Jun 1, 2026
e091b77
fix(dev-server-legacy): add --experimental-strip-types to test script
bennypowers Jun 1, 2026
99e421f
fix: use node glob to find all test files consistently
bashmish Jun 29, 2026
8ca78c4
chore(dev-server-legacy): add comment about future src import rewrite
bennypowers Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/dev-server-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"scripts": {
"build": "tsc",
"start": "wds --open --config demo/server.config.mjs",
"test:node": "mocha \"test/**/*.test.ts\" --require ts-node/register --reporter dot",
"test:watch": "mocha \"test/**/*.test.ts\" --require ts-node/register --watch --watch-files src,test"
"test:node": "node --experimental-strip-types --test --test-force-exit \"test/**/*.test.ts\"",
"test:watch": "node --experimental-strip-types --test --test-force-exit --watch \"test/**/*.test.ts\""
},
"files": [
"*.d.ts",
Expand Down
26 changes: 13 additions & 13 deletions packages/dev-server-legacy/test/transform-html.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { expect } from 'chai';
import { describe, it } from 'node:test';
import assert from 'node:assert/strict';
import { createTestServer } from '@web/dev-server-core/test-helpers';
import { fetchText, expectIncludes } from '@web/dev-server-core/test-helpers';

import { legacyPlugin } from '../src/legacyPlugin.js';
import { modernUserAgents, legacyUserAgents } from './userAgents.js';
// rewrite to ../src/legacyPlugin.ts when TS 5.7+ / rewriteRelativeImportExtensions
import { legacyPlugin } from '../dist/legacyPlugin.js';
import { modernUserAgents, legacyUserAgents } from './userAgents.ts';
Comment thread
bashmish marked this conversation as resolved.

const htmlBody = `
<html>
Expand All @@ -25,12 +27,10 @@ const inlineScriptHtmlBody = `
</body>
</html>`;

describe('legacyPlugin - transform html', function () {
this.timeout(10000);

describe('legacyPlugin - transform html', { timeout: 10000 }, () => {
it(`does not do any work on a modern browser`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand All @@ -48,13 +48,13 @@ describe('legacyPlugin - transform html', function () {
headers: { 'user-agent': modernUserAgents['Chrome 78'] },
});

expect(text.trim()).to.equal(htmlBody.trim());
assert.equal(text.trim(), htmlBody.trim());
server.stop();
});

it(`injects polyfills into the HTML page on legacy browsers`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand All @@ -80,7 +80,7 @@ describe('legacyPlugin - transform html', function () {

it(`injects systemjs param to inline modules`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand All @@ -104,7 +104,7 @@ describe('legacyPlugin - transform html', function () {

it(`handles inline scripts`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand All @@ -131,7 +131,7 @@ describe('legacyPlugin - transform html', function () {

it(`can request inline scripts`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand All @@ -158,7 +158,7 @@ describe('legacyPlugin - transform html', function () {

it(`includes url parameters in inline script key`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand Down
20 changes: 10 additions & 10 deletions packages/dev-server-legacy/test/transform-js.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { expect } from 'chai';
import { describe, it } from 'node:test';
import assert from 'node:assert/strict';
import { createTestServer } from '@web/dev-server-core/test-helpers';
import { fetchText, expectIncludes, expectNotIncludes } from '@web/dev-server-core/test-helpers';

import { legacyPlugin } from '../src/legacyPlugin.js';
import { modernUserAgents, legacyUserAgents } from './userAgents.js';
// rewrite to ../src/legacyPlugin.ts when TS 5.7+ / rewriteRelativeImportExtensions
import { legacyPlugin } from '../dist/legacyPlugin.js';
import { modernUserAgents, legacyUserAgents } from './userAgents.ts';

const modernCode = `
class Foo {
Expand All @@ -16,13 +18,11 @@ async function doImport() {

console.log(window?.foo?.bar);`;

describe('legacyPlugin - transform js', function () {
this.timeout(10000);

describe('legacyPlugin - transform js', { timeout: 10000 }, () => {
for (const [name, userAgent] of Object.entries(modernUserAgents)) {
it(`does not do any work on ${name}`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand All @@ -39,15 +39,15 @@ describe('legacyPlugin - transform js', function () {
const text = await fetchText(`${host}/app.js`, {
headers: { 'user-agent': userAgent },
});
expect(text.trim()).to.equal(modernCode.trim());
assert.equal(text.trim(), modernCode.trim());
server.stop();
});
}

for (const [name, userAgent] of Object.entries(legacyUserAgents)) {
it(`transforms to es5 on ${name}`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand Down Expand Up @@ -78,7 +78,7 @@ describe('legacyPlugin - transform js', function () {

it(`transforms to SystemJS when systemjs paramater is given ${name}`, async () => {
const { server, host } = await createTestServer({
rootDir: __dirname,
rootDir: import.meta.dirname,
plugins: [
{
name: 'test',
Expand Down
Loading