Skip to content

Give keys.py's cross-module primitives a real interface#49

Merged
lesnik512 merged 2 commits into
mainfrom
worktree-public-keys-primitives
Jul 13, 2026
Merged

Give keys.py's cross-module primitives a real interface#49
lesnik512 merged 2 commits into
mainfrom
worktree-public-keys-primitives

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Summary

  • Drops the leading underscore on six compose2pod/keys.py names — _Expand, _is_number, _validate_map, _extra_host_pairs, _key_value_pairs, _pairs_to_mapping — that five other production modules (pod.py, resources.py, emit.py, stores.py's neighbor extends.py) and four test files already import directly. The underscore no longer reflected reality; this makes the real interface honest.
  • Pure rename: no signature, logic, or behavior changes. Token = str | Expand (already public) is unchanged.
  • Adds Token/Expand entries to architecture/glossary.md now that they're openly shared vocabulary.
  • Candidate Port the compose-to-podman-pod converter into compose2pod #1 from the 2026-07-13 architecture review (companion to Derive extends' merge policy from KeySpec #47/Adopt planning-convention v1.1.2 and migrate planning docs #2, which already shipped).

Full rationale: planning/changes/2026-07-13.07-public-keys-primitives.md.

Test plan

  • just test-ci — 405 passed, 100% line coverage (identical count to baseline — a rename adds no tests)
  • just lint-ci — clean
  • Task-scoped subagent review — approved, no findings
  • Final whole-branch subagent review — ready to merge, no findings

@lesnik512 lesnik512 merged commit 6a5db4d into main Jul 13, 2026
7 checks passed
@lesnik512 lesnik512 deleted the worktree-public-keys-primitives branch July 13, 2026 16:58
@lesnik512 lesnik512 mentioned this pull request Jul 13, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant