-
Notifications
You must be signed in to change notification settings - Fork 35
fix: constrain torch version and add transformers dependency #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mahone3297
commented
Feb 3, 2026
- Change torch requirement from >= 2.6 to <= 2.8 for version compatibility
- Add transformers package as explicit dependency
- Change torch requirement from >= 2.6 to <= 2.8 for version compatibility - Add transformers package as explicit dependency
Summary of ChangesHello @mahone3297, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's dependency management by constraining the acceptable Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project's dependencies by constraining the torch version and adding transformers as a dependency. My review includes suggestions to refine these dependency specifications to prevent potential compatibility issues. Specifically, I recommend re-adding a lower bound for the torch version and specifying a version range for the new transformers dependency to ensure more stable and predictable builds.
| requires-python = ">=3.10" | ||
| dependencies = [ | ||
| "torch >= 2.6", | ||
| "torch <= 2.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The torch dependency has been changed from >= 2.6 to <= 2.8. This removes the lower version bound, which could allow older, incompatible versions of PyTorch to be installed. To ensure compatibility, it's better to specify both a lower and an upper bound, combining the previous constraint with the new one.
| "torch <= 2.8", | |
| "torch >= 2.6, <= 2.8", |
| "torch >= 2.6", | ||
| "torch <= 2.8", | ||
| "torchvision", | ||
| "transformers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transformers dependency is added without a version constraint. This can lead to unexpected issues if a future version introduces breaking changes. The development dependencies specify transformers == 4.52.4. It is a good practice to specify a compatible version range to ensure stability.
| "transformers", | |
| "transformers >= 4.52.4, < 5.0", |