fix(client): fire onerror only once when the standalone GET stream fails - #2418
Open
pablopupo wants to merge 1 commit into
Open
fix(client): fire onerror only once when the standalone GET stream fails#2418pablopupo wants to merge 1 commit into
pablopupo wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: c4ad5e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
pablopupo
force-pushed
the
fix/868-double-onerror-on-close
branch
from
August 4, 2026 18:55
1d9dea4 to
c4ad5e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #880 to v2, following the maintainer request in #868. Fixes #868.
Motivation and Context
_startOrAuthSsereported a failure throughonerrorand then rethrew it. The standalone GET and reconnection call sites caught that same rejection and reported it again, so one stream failure could produce two callbacks.The helper now only propagates failures. Each call site that owns a stream reports the failure once.
resumeStream()keeps its existing contract: the returned promise rejects andonerroris called once. The 401/403 authentication retry path continues to return through the recursive call without taking error ownership.How Has This Been Tested?
Four event-driven regressions cover:
close()aborting an in-flight standalone GET;resumeStream()rejection plus oneonerrorcallback;_send.The focused transport tests pass with 73 tests. The full client suite passes with 801 tests, and the repository's non-e2e package matrix,
check:all,build:all, documentation build, distribution type smoke test, and changeset check also pass.Breaking Changes
None.
Types of changes
Checklist