fix: add clipboard fallback for non-secure contexts#1404
Open
xlyoung wants to merge 1 commit into
Open
Conversation
navigator.clipboard.writeText() requires a secure context (HTTPS or
localhost). When running Inspector in Docker on a local network over
HTTP, the Clipboard API throws a DOMException, causing the 'Copy
Servers File' and 'Copy Server Entry' buttons to fail.
This adds a fallback that uses a temporary textarea element with
document.execCommand('copy') when the Clipboard API is unavailable.
Fixes modelcontextprotocol#913
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking 'Copy Servers File' or 'Copy Server Entry' buttons fails when Inspector is hosted over HTTP (not HTTPS) on a local network, such as Docker compose deployments.
Root cause:
navigator.clipboard.writeText()requires a secure context (HTTPS or localhost). When accessed via HTTP on a LAN IP, the Clipboard API throws aDOMException, and the error toast shows the raw exception message.Fix
Add a
copyToClipboardutility that:navigator.clipboard+window.isSecureContext)<textarea>+document.execCommand('copy')otherwiseThis is the same fallback pattern used by many popular libraries (e.g.,
clipboard-polyfill).Testing
Fixes #913