reexec: test cmd.Cancel, bump minimum go version to go1.20#194
Merged
reexec: test cmd.Cancel, bump minimum go version to go1.20#194
Conversation
This requires go1.20 or up; https://go-review.googlesource.com/23300 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5c82dea to
d197f51
Compare
kolyshkin
approved these changes
Aug 13, 2025
Collaborator
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM
(I dream about the day we can drop Go 1.18 entirely, and just use supported versions)
Member
Author
|
Yeah, it's a bit of extra hassle, then again for modules that don't need it, it reduces having to update those. Perhaps we should check the |
Member
Author
|
This seems to work; I'll open a follow-up for that one. #!/usr/bin/env bash
set -eu
# Check if the module's declared Go version is <= current Go version
go_version="$(go env GOVERSION)"
go_version="${go_version#go}"
packages=""
for p in */; do
[ -f "$p/go.mod" ] || continue
if ! (cd "$p" && go list -m -f "{{if gt .GoVersion \"$go_version\"}}ko{{end}}" | grep -q ko); then
packages+="${p%/} "
fi
done
echo "PACKAGES=${packages}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reexec: test cmd.Cancel, bump minimum go version to go1.20
This requires go1.20 or up; https://go-review.googlesource.com/23300