Migrate to gotest.tools :)#2220
Merged
fcrisciani merged 2 commits intomoby:masterfrom Jul 6, 2018
vdemeester:to-gotest.tools
Merged
Migrate to gotest.tools :)#2220fcrisciani merged 2 commits intomoby:masterfrom vdemeester:to-gotest.tools
fcrisciani merged 2 commits intomoby:masterfrom
vdemeester:to-gotest.tools
Conversation
Member
Contributor
|
@thaJeztah I bumped all dependencies which libnetwork and moby had in common to the version used in moby. I didn't look for dependencies which could be removed from libnetwork. The new dependencies at the bottom of the file were added because one of the new versions of an existing dependency needed them. It seems some of the original dependencies can be removed, taking the new ones with them. Great! |
euanh
approved these changes
Jul 5, 2018
thaJeztah
approved these changes
Jul 5, 2018
| assert.False(t, expected.Exists()) | ||
| assert.Check(t, !expected.Exists()) | ||
| err := store.PutObjectAtomic(expected) | ||
| if err != nil { |
Member
There was a problem hiding this comment.
For someone that has some time to spend; these can be changed to use assert.NilError(t, err)
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
rebased and fixed the conflict |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2213
Signed-off-by: Vincent Demeester vincent@sbr.pm