You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@larsoner, turns out when the specifiers/markers are being prettified, ' in pyproject.toml becomes " (e.g., 'Darwin' -> "Darwin"). Was enough for the check for changed requirements to be triggered.
Just added the conversion of any double back to single quotation marks.
Great! Will manually merge once CircleCI comes back happy, other than the expected 45 warnings 😓
(FYI in the latest commit message to save some CI cycles you could have pushed with [skip azp] to skip Azure and [skip actions] to skip GHA since your changes shouldn't affect any of those runs!)
(FYI in the latest commit message to save some CI cycles you could have pushed with [skip azp] to skip Azure and [skip actions] to skip GHA since your changes shouldn't affect any of those runs!)
Sure, I'll keep that in mind for these types of things! Is [ci skip] then an alias for Azure and GHA skipping?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Discussed in #13641
What does this implement/fix?
@larsoner, turns out when the specifiers/markers are being prettified,
'in pyproject.toml becomes"(e.g.,'Darwin'->"Darwin"). Was enough for the check for changed requirements to be triggered.Just added the conversion of any double back to single quotation marks.