Add voices api endpoint#47
Closed
mmwillet wants to merge 3 commits into
Closed
Conversation
mmwillet
commented
May 1, 2025
mmwillet
left a comment
mmwillet
left a comment
Owner
Author
There was a problem hiding this comment.
I'm going to come back to this and refactor the task response pattern to be more flexible.
| } | ||
| for (auto voice : list_voices(runner)) { | ||
| if (!task->message.empty()) { | ||
| task->message += ","; |
Owner
Author
There was a problem hiding this comment.
We really shouldn't use the message output for passing data back from the workers.
| res_error(res, formatted_error); | ||
| return; | ||
| } | ||
| std::vector<std::string> voices = split(rtask->message, ","); |
Owner
Author
There was a problem hiding this comment.
This is very inefficient and a more generic response pattern should be preferred (rather than parsing a string list from the message).
danielzgtg
reviewed
May 1, 2025
danielzgtg
reviewed
May 1, 2025
Owner
Author
|
no immediate need for this. I am going to close this for now. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds simple voices api endpoint per #17