Fix tag URL is [object object] & Add some updates#7
Open
cool4zbl wants to merge 6 commits into
Open
Conversation
|
I just started looking into [object Object] bug today but decided to check here first. Glad I did, thanks for the patch! |
Author
|
@autonome Glad to help you. 😄 |
|
Hi @mixu, are you interested in giving us commit access? Or if you do no plan to accept any PRs, do you recommend we fork active dev to a new repo? THanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I've used this tool to build my Ghost blog, and it was so cool!
However, I found there were somewhere I was not so satisfied and even found a small bug of generating the tag URL, so I made some updates and fix the bug.
E.g.
{hostname}/2017-07-02-welcome-to-ghost.html->{hostname}/2017-07-02-welcome-to-ghost/.E.g.
{hostname}/2017-07-02-welcome-to-ghost/index.html->{hostname}/2017-07-02-welcome-to-ghost/colorspackage for debugging easily.@mixu
Please review, thanks! 😃