Skip to content

Fix tag URL is [object object] & Add some updates#7

Open
cool4zbl wants to merge 6 commits into
mixu:masterfrom
cool4zbl:dev
Open

Fix tag URL is [object object] & Add some updates#7
cool4zbl wants to merge 6 commits into
mixu:masterfrom
cool4zbl:dev

Conversation

@cool4zbl
Copy link
Copy Markdown

@cool4zbl cool4zbl commented Jul 2, 2017

Hi there, I've used this tool to build my Ghost blog, and it was so cool!
However, I found there were somewhere I was not so satisfied and even found a small bug of generating the tag URL, so I made some updates and fix the bug.

  • Fix tag URL is [object object]
  • Beautify the post URLs in the index page.
    E.g. {hostname}/2017-07-02-welcome-to-ghost.html -> {hostname}/2017-07-02-welcome-to-ghost/.
    E.g. {hostname}/2017-07-02-welcome-to-ghost/index.html -> {hostname}/2017-07-02-welcome-to-ghost/
  • Use colors package for debugging easily.

@mixu
Please review, thanks! 😃

@autonome
Copy link
Copy Markdown

I just started looking into [object Object] bug today but decided to check here first. Glad I did, thanks for the patch!

@cool4zbl
Copy link
Copy Markdown
Author

@autonome Glad to help you. 😄

@autonome
Copy link
Copy Markdown

autonome commented Nov 5, 2018

Hi @mixu, are you interested in giving us commit access? Or if you do no plan to accept any PRs, do you recommend we fork active dev to a new repo?

THanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants