Open DHC + Pedestal Goal

[eternalcode0]

Added "Open + Ped" goal. Makes the DHC open and requires you to activate pedestal from within the DHC sanctuary. The DHC boss door will have the same "blocker" used from the Hyrule castle garden to DHC as the "DHC Opens: Pedestal" setting.

Recreated from #106 after a rebase.

[Catobat]

Please put the block that starts here in an !else block so it doesn't overwrite anything that happened above when OPENPED is defined.

[eternalcode0]

I still need to run a few tests to ensure all the correct settings involving DHC/goal are applying correctly, however, in my brief testing I've already seen some weird results where Yaml settings don't seem to load correctly. Would the additional "DHC Opens" setting have caused this or is it possibly something with my environment?

I randomized on this branch with the CLI's LoadYAML command and the Advanced_3 yaml unchanged. The resulting rom didn't have the correct settings, it looked like it had default settings or something similar. Goron sets was 0, Cucco Rounds was 1, RGB fusions were Closed, etc. When I swapped to the staging branch and tried the same thing I got the expected rom from the same Advanced_3 yaml.

[Catobat]

I still need to run a few tests to ensure all the correct settings involving DHC/goal are applying correctly, however, in my brief testing I've already seen some weird results where Yaml settings don't seem to load correctly. Would the additional "DHC Opens" setting have caused this or is it possibly something with my environment?

I randomized on this branch with the CLI's LoadYAML command and the Advanced_3 yaml unchanged. The resulting rom didn't have the correct settings, it looked like it had default settings or something similar. Goron sets was 0, Cucco Rounds was 1, RGB fusions were Closed, etc. When I swapped to the staging branch and tried the same thing I got the expected rom from the same Advanced_3 yaml.

That's very odd, adding a new option shouldn't affect the existing YAMLs at all. What does it look like when you use Options after LoadYAML in both branches?

I also just noticed that the logic file doesn't actually add the new option.