Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

Reformat chart templates with minor property fixes#1647

Merged
pjuarezd merged 5 commits into
minio:masterfrom
dnskr:reformat_chart_templates
Jun 27, 2023
Merged

Reformat chart templates with minor property fixes#1647
pjuarezd merged 5 commits into
minio:masterfrom
dnskr:reformat_chart_templates

Conversation

@dnskr

@dnskr dnskr commented Jun 18, 2023

Copy link
Copy Markdown
Contributor

Description

The PR reformats chart templates to common more compact and readable style.
The PR also includes a few minor property fixes.

Details

Similar reformatting changes: minio/minio#16947 apache/superset#23681

Operator template fixes:

  • Console deployment used operator.imagePullSecrets property
  • Console deployment used operator.runtimeClassName property
  • Console container used operator.image.pullPolicy property

Operator values.yaml:

  • Declare missing runtimeClassName and env properties
  • Fix initcontainers property name

@shtripat shtripat requested review from dvaldivia and pjuarezd June 23, 2023 03:37
@dnskr

dnskr commented Jun 27, 2023

Copy link
Copy Markdown
Contributor Author

@harshavardhana Merge conflict resolved.

@harshavardhana

Copy link
Copy Markdown
Member

PTAL @pjuarezd

@pjuarezd pjuarezd merged commit 40465cb into minio:master Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants