migration: unify legacy IAM resources into PlatformAccess CRD#47
Open
JoseSzycho wants to merge 5 commits into
Open
migration: unify legacy IAM resources into PlatformAccess CRD#47JoseSzycho wants to merge 5 commits into
JoseSzycho wants to merge 5 commits into
Conversation
…cess CRD using server-side apply
…rmAccess resource
3 tasks
scotwells
previously approved these changes
Jul 1, 2026
scotwells
left a comment
Contributor
There was a problem hiding this comment.
Have some linter failures. Changes look good though. What's the migration process look like for existing resources? Is that documented anywhere?
… evaluation controller
Contributor
Author
|
@scotwells Thanks, I just fixed the listing error. The migration already started. Right now, a controller in Milo translates the legacy CRDs to PlatformAccess in real time. So Milo already have all existent PlatformAccess CR for each user with the corresponding state. Once this PR is approved again, I will left it as it is, and create a final PR in Milo, as I need to update the User controller to update the User.Status using the PlatformAccess, once that final PR is deployed, I just need to merge this PR and the existing one in auth-provider-zitadel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformAccess Migration
This migration bumps the
go.miloapis.com/milodependency tov0.29.1and unifies the three legacy IAM resources (PlatformAccessApproval,PlatformAccessRejection, andUserDeactivation) into the single, unifiedPlatformAccessCRD.Key Changes
Dependency Upgrade:
go.miloapis.com/milotov0.29.1ingo.mod.sigs.k8s.io/controller-runtimetov0.23.3.CRD Consolidation:
PlatformAccessApproval,PlatformAccessRejection, andUserDeactivationacross RBAC configurations, controller logic, and test suites.Statefield on the unifiedPlatformAccessCRD:PlatformAccessStateSuspendedPlatformAccessStatePendingPlatformAccessStateApproved