feat(AudioPlayer): enhance Storybook controls with all component props#44
Merged
Conversation
- Add comprehensive argTypes for all AudioPlayer props - Add conditional waveform controls (waveColor, progressColor, waveformHeight) - Set sensible default values for demo - Update Default story to use args for interactive controls - Add component description to docs
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the Storybook documentation for the AudioPlayer component by adding comprehensive interactive controls and improving the documentation experience. The changes make it easier for developers to explore and understand the AudioPlayer component's various configuration options.
Changes:
- Added comprehensive argTypes for all user-configurable props including variant, size, title, and display controls
- Added conditional waveform-specific controls (waveColor, progressColor, waveformHeight) that only appear when the waveform variant is selected
- Updated the Default story to use args for interactive controls instead of hardcoded props
- Added component description to the documentation page
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- showDuration: false → true (matches component default) - waveformHeight: 80 → 64 (matches component default)
Deploying ui with
|
| Latest commit: |
9b04b7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b700bcdf.ui-6d0.pages.dev |
| Branch Preview URL: | https://feature-audio-player-update.ui-6d0.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audio-player-update.mov