feat(DateInput): Add calendar picker with width/size props and dark mode fixes#21
Merged
Merged
Conversation
garrity-miepub
force-pushed
the
feature/date-input-update
branch
from
7ca6769 to
5c74b6e
Compare
Deploying ui with
|
| Latest commit: |
543bcd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1568de4.ui-6d0.pages.dev |
| Branch Preview URL: | https://feature-date-input-update.ui-6d0.pages.dev |
Features: - Add showCalendar prop to display a calendar icon button - Calendar picker with month/year dropdown navigation - Click outside and Escape key to close calendar - Today button for quick date selection - Pre-filled dates highlight selected day Props: - Add width prop with full, fit, fixed options - Support size variants (sm, md, lg) for calendar version - Properly handle required asterisk and error states Styling: - Calendar popup with proper dark mode support - Selected day and today highlighting - Responsive positioning relative to input Fixes: - Fix calendar icon positioning with label/error/helper text - Fix size prop type handling (null/undefined fallback to md) - Use inline styles for error/required colors to avoid CSS specificity issues Storybook: - Add width control dropdown - Add calendar-specific stories (WithCalendar, WithCalendarPreFilled, etc.) - Fix text-destructive color override in docs dark mode using CSS variable
garrity-miepub
force-pushed
the
feature/date-input-update
branch
from
5c74b6e to
543bcd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
Props:
Styling:
Fixes:
Storybook:
dateinput-update.mov