Fix: Video upload from the device is fixed in browser#337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a concise summary you can use for updates, standups, or PR notes:
PulseVault Video Upload Fix Summary
Resolved a video upload issue caused by Mixed Content errors during TUS uploads. While the
/v1/video/reserveendpoint was already returning HTTPS URLs, the underlying TUS server (@tus/serverviasrvx) was still generatingLocationheaders with HTTP URLs, causing browsers to block uploads when accessed from the HTTPS frontend.Changes Implemented
trustProxy: trueinserver.tsso Fastify correctly respectsx-forwarded-protoheaders and detects HTTPS requests behind the proxy.rewriteRawLocationHeaderpre-handler inpulsevault.tsfor both PulseVault route scopes.reply.raw.setHeader()andreply.raw.writeHead()responses to rewrite anyLocation: http://...headers tohttps://...whenever requests originate from an HTTPS frontend.timehuddle-api) running under the root account.Verification
https://timehuddledev.os.mieweb.org).Locationheaders.204 Upload-Offsetresponses).