Cmyers launchpad refactor#20
Merged
Merged
Conversation
Replace inlined curl/jq logic with reusable composite actions (get-container, create-container, delete-container, wait-for-job) and reorganize control flow. Add an event classification step to decide manage vs delete, introduce a prepare step to build container name/template, and a planning step to determine create/recreate/delete actions. Update metadata and header docs to explain LaunchPad behavior and pinning constraints. Overall this makes the action more modular, easier to maintain, and avoids duplicating API and polling logic.
Replace inlined curl/jq logic with reusable composite actions (get-container, create-container, delete-container, wait-for-job) and reorganize control flow. Add an event classification step to decide manage vs delete, introduce a prepare step to build container name/template, and a planning step to determine create/recreate/delete actions. Update metadata and header docs to explain LaunchPad behavior and pinning constraints. Overall this makes the action more modular, easier to maintain, and avoids duplicating API and polling logic.
runleveldev
requested changes
Jun 19, 2026
Remove the long inlined bash polling step and an earlier pinning comment, and delegate job-wait logic to the reusable action mieweb/opensource-server/.github/actions/wait-for-job@latest. The new step forwards api_url, api_key and job_id inputs instead of embedding curl/jq polling logic, simplifying the action and centralizing maintenance.
runleveldev
approved these changes
Jun 19, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly refactors the
action.ymlworkflow for the MIEWeb LaunchPad action, modularizing the logic for container management by delegating API calls to reusable composite actions frommieweb/opensource-server/.github/actions. The workflow is now more maintainable, robust, and easier to extend, with clearer separation of concerns for event classification, container lifecycle management, and reporting.Key changes include:
Workflow modularization and delegation:
get-container,create-container, anddelete-container. This reduces code duplication and centralizes API interaction logic. [1] [2]Improved event handling and classification:
Container lifecycle management:
Status reporting and error handling:
get-containeraction, improving reliability and simplifying error handling. Adds a dedicated reporting step with clearer output and error messages if containers are not found or not running.Documentation and metadata: