Skip to content

Fixes Request Header Logging When Using WinHttpHandler - #2028

Merged
Peter Ombwa (peombwa) merged 2 commits into
features/2.0from
po/FixFinalHttpHandler
May 23, 2023
Merged

Fixes Request Header Logging When Using WinHttpHandler#2028
Peter Ombwa (peombwa) merged 2 commits into
features/2.0from
po/FixFinalHttpHandler

Conversation

@peombwa

Copy link
Copy Markdown
Member

Fixes #1916

Changes proposed in this pull request

  • Clones request before reading/sanitizing request headers for logging to avoid thread safety issues when WinHttpHandler is used as the final handler (.NET Fx).
  • Updates how sdkVersion and client-request-id are set on outgoing request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue running Get-MgUser in v2.0.0-Preview5 - Collection was modified; enumeration operation may not execute. Possible PageSize issue in PS 5.1

2 participants