Fix issues when running without debugging and debugged code terminates by DonJayamanne · Pull Request #249 · microsoft/vscode-python

DonJayamanne · 2017-11-16T21:25:09Z

Fixes Not working Ctrl+F5 for a second time #25, Error "Cannot read property 'openConfigFile' of undefined" when starting python program without the debugger #32, Python: 'Start without debugging shortcut’ has a problem. #35, Ctrl+F5 does not start without debugging #235, Running python code without debugging only works once #242 (unable to run without debugging using CTRL+F5)
Fixes Debug error when finished running code in integrated/external terminal #191, Debug adapter process has terminated unexpectedly #158, Always getting a "Debug adapter process has terminated unexpectedly" error when using "console" option #24, Debug: Run in External Terminal Returns Error Message on Exit #136 (error message displayed when debugged code terminates)
Fixes Cannot read property "Threads" of null #157 (debugger crashes when python program does not launch)
Fixes terminal.external.osxExec not respected as debug terminal? #114, Python / envFile in launch.json causes issues #149, runInTerminalRequest does not work on Mac OS #250 (use vscode infrastructure to launch debugger in integrated and external terminals)
Fixes Discuss the need for the prompt at the end of the execution of a program #239 Remove prompt added to pause terminal upon program completion

Archive of 0.7.0

* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)

brettcannon

You probably want to read https://www.python.org/dev/peps/pep-0008/ 😉

brettcannon · 2017-11-16T22:04:39Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

@@ -0,0 +1,150 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+


"""Run a block of code or Python file."""

brettcannon · 2017-11-16T22:04:59Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+
+import sys
+import os
+from os import path


import os.path.

brettcannon · 2017-11-16T22:06:56Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+    import visualstudio_py_util as _vspu
+except:
+    traceback.print_exc()
+    print('''Internal error detected. Please copy the above traceback and report at


brettcannon · 2017-11-16T22:07:17Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+LOAD = _vspu.to_bytes('LOAD')
+
+def launch():
+    # Arguments are:


Should be in a docstring.

brettcannon · 2017-11-16T22:07:36Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+    # 6. Startup script name.
+    # 7. Script arguments.
+
+    # change to directory we expected to start from.


"Change" (didn't capitalize the comments).

brettcannon · 2017-11-16T22:25:11Z

src/client/debugger/DebugClients/NonDebugClient.ts

-        return [this.args.program].concat(programArgs);
+    protected getLauncherFilePath(): string {
+        const currentFileName = module.filename;
+        const ptVSToolsPath = path.join(path.dirname(currentFileName), '..', '..', '..', '..', 'pythonFiles', 'PythonTools');


Is there no better way to get to the extension's directory than manually walking backwards?

No, the extension directory is exposed to the extension, but the debugger is launched in a separate process and we don't have access to the same information that the extension has.

brettcannon · 2017-11-16T22:26:34Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+        sys.stderr.write(out)
+        sys.stderr.flush()
+
+def is_same_py_file(file1, file2):


file_1, file_2 or something as I barely noticed the two different variable names below with the numbers so close to the text.

brettcannon · 2017-11-16T22:28:03Z

src/client/debugger/DebugClients/LocalDebugClient.ts

+    // tslint:disable-next-line:member-ordering
+    protected handleProcessOutput(proc: ChildProcess, failedToLaunch: (error: Error | string | Buffer) => void) {
+        proc.on('error', error => {
+            // TODO: This condition makes no sense (refactor)


How bad would it be to fix this now since we all know TODOs never get done. 😉

brettcannon · 2017-11-16T22:29:22Z

src/client/debugger/Main.ts

        }
-        // If launching the integrated terminal is not supported, then defer to external terminal 
+        // If launching the integrated terminal is not supported, then defer to external terminal
        // that will be displayed by our own code


Missing a period.

brettcannon · 2017-11-16T22:30:09Z

src/client/debugger/Main.ts

-        }
-        else {
-            this.pythonProcess.SendResumeThread(pyThread.Id);
+        if (this.launchArgs.noDebug !== true) {


Wouldn't this be !this.launchArgs.noDebug, or does this have to do with null/undefined? Same with the explicit comparisons against boolean values below.

DonJayamanne · 2017-11-17T00:21:34Z

@brettcannon all fixed.

DonJayamanne · 2017-11-17T17:57:44Z

@brettcannon , I came across a bug when running on Mac OS (I've fixed the issue with 09b3359 and 9616eef, its the last two commit in this PR) and also filed an issue in the vscode repo.

DonJayamanne · 2017-11-21T23:03:42Z

@brettcannon all comments have been resolved.

brettcannon

Minor refactoring to do, but I trust you to do it without me blocking you on another round of review.

brettcannon · 2017-11-21T23:13:23Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+    4. Debug options (not used).
+    5. '-m' or '-c' to override the default run-as mode. [optional].
+    6. Startup script name.
+    7. Script arguments


Either add a . or drop them all from the list.

brettcannon · 2017-11-21T23:13:42Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+LOAD = _vspu.to_bytes('LOAD')
+
+def launch():
+    """Arguments are:


Add a one-sentence explanation of what this function does.

brettcannon · 2017-11-21T23:15:22Z

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

+OUTP = _vspu.to_bytes('OUTP')
+LOAD = _vspu.to_bytes('LOAD')
+
+def launch():


Maybe rename to parse_argv() that teases out the details and then drop the call to run()? Then in the __name__ == '__main__' can call parse_argv() and then call run()?

Totally agreed, that's cleaner (SOC)

* upstream/master: Fixes #22 to Detect anaconda from known locations (#221) Use workspaceFolder token instead of workspaceRoot (#267) Fix registry lookup response (#224) Fix issues when running without debugging and debugged code terminates (#249)

octref and others added 11 commits November 3, 2017 13:11

Fix microsoft/vscode#37627 (#1368)

ecc1ca9

Version 0.7.0 of extension (#1381)

7c5778c

Archive of 0.7.0

Update README.md

9d1bf82

Update README.md

ffba179

sync fork with upstream

905c713

fix readme

acc2109

run without debugging

d32a546

send terminated event when process ends and fix linters

3f14d0a

gracefully handle program termination

f37803f

use vscode infrastructure to launch code in terminals

d69940e

brettcannon changed the title ~~Fix issues when running without debuging and debugged code terminates~~ Fix issues when running without debugging and debugged code terminates Nov 16, 2017

DonJayamanne added 5 commits November 16, 2017 14:05

merged upstream

d392e8b

merged

11c9514

ensure to check if launchArgs is not null

38befc0

ensure to check if launchArgs is not null

bea91fc

ensure to check if launchArgs is not null

0bb9054

brettcannon suggested changes Nov 16, 2017

View reviewed changes

DonJayamanne added 2 commits November 16, 2017 16:06

fix code review comments

a105a20

fixed code review comments

8b2fd7c

DonJayamanne added 4 commits November 16, 2017 16:22

Merge branch 'master' into RunWithoutDebug

5a7d21e

Merge branch 'master' into RunWithoutDebug

acd90c5

fixes #250, do not copy all env variables

09b3359

bug fix, launch using vscode and then fallback

9616eef

DonJayamanne added this to the December 2017 milestone Nov 17, 2017

fix linter issue

f9fe2a8

brettcannon approved these changes Nov 21, 2017

View reviewed changes

DonJayamanne added 4 commits November 21, 2017 16:33

fix code review issues

79aa7c1

running without debugging without workspaces

984602e

Merge branch 'master' into RunWithoutDebug

d65eece

Merge branch 'master' into RunWithoutDebug

650ec17

DonJayamanne merged commit a6b49d2 into microsoft:master Nov 22, 2017

DonJayamanne mentioned this pull request Nov 22, 2017

runInTerminalRequest does not work on Mac OS #250

Closed

DonJayamanne deleted the RunWithoutDebug branch December 12, 2017 21:22

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

		@@ -0,0 +1,150 @@
		# Copyright (c) Microsoft Corporation. All rights reserved.
		# Licensed under the MIT License.

Conversation

DonJayamanne commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DonJayamanne commented Nov 17, 2017

Uh oh!

DonJayamanne commented Nov 17, 2017

Uh oh!

DonJayamanne commented Nov 21, 2017

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DonJayamanne commented Nov 16, 2017 •

edited

Loading

DonJayamanne Nov 16, 2017 •

edited

Loading