Refactor NativePythonFinderImpl for better disposable management#1144
Merged
karthiknadig merged 2 commits intomainfrom Feb 2, 2026
Merged
Refactor NativePythonFinderImpl for better disposable management#1144karthiknadig merged 2 commits intomainfrom
karthiknadig merged 2 commits intomainfrom
Conversation
karthiknadig
added
the
bug
Tyriar
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1141
Improve management of disposables in the NativePythonFinderImpl class to enhance resource cleanup and prevent potential memory leaks.
Changes
startDisposablesarray to track disposables created instart()dispose()to properly stop the worker pool and dispose all tracked resourceslog,telemetry,onError, etc.) are properly cleaned up