Skip to content

[code-simplifier] simplify: cleanup in crash/hang dump CLI options from PR #8666 #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
May 31, 2026
Merged

[code-simplifier] simplify: cleanup in crash/hang dump CLI options from PR #8666 #8716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Platform/Microsoft.Testing.Extensions.CrashDump/CrashDumpCommandLineProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ public override Task<ValidationResult> ValidateOptionArgumentsAsync(CommandLineO

public override Task<ValidationResult> ValidateCommandLineOptionsAsync(ICommandLineOptions commandLineOptions)
=> IsCrashDumpMainOptionMissing(commandLineOptions)
? ValidationResult.InvalidTask(CrashDumpResources.MissingCrashDumpMainOption)
: AreCrashReportOptionsMutuallyExclusive(commandLineOptions)
? ValidationResult.InvalidTask(CrashDumpResources.CrashReportAndIfSupportedAreMutuallyExclusiveErrorMessage)
: IsCrashReportUnsupportedOnCurrentPlatform(commandLineOptions)
? ValidationResult.InvalidTask(CrashDumpResources.CrashReportNotSupportedOnWindowsErrorMessage)
: ValidationResult.ValidTask;
? ValidationResult.InvalidTask(CrashDumpResources.MissingCrashDumpMainOption)
: AreCrashReportOptionsMutuallyExclusive(commandLineOptions)
? ValidationResult.InvalidTask(CrashDumpResources.CrashReportAndIfSupportedAreMutuallyExclusiveErrorMessage)
: IsCrashReportUnsupportedOnCurrentPlatform(commandLineOptions)
? ValidationResult.InvalidTask(CrashDumpResources.CrashReportNotSupportedOnWindowsErrorMessage)
: ValidationResult.ValidTask;

private static bool AreCrashReportOptionsMutuallyExclusive(ICommandLineOptions commandLineOptions)
=> commandLineOptions.IsOptionSet(CrashDumpCommandLineOptions.CrashReportOptionName) &&
Expand Down
7 changes: 3 additions & 4 deletions src/Platform/Microsoft.Testing.Extensions.HangDump/HangDumpProcessLifetimeHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,11 @@ public async Task BeforeTestHostProcessStartAsync(CancellationToken cancellation
// supported value (see MapToSupportedDumpType) and emit a single informational
// message so the CI log makes the substitution visible without breaking the run.
string requested = dumpTypeIfSupported[0];
string mapped = HangDumpCommandLineProvider.MapToSupportedDumpType(requested);
_dumpType = mapped;
if (!string.Equals(mapped, requested, StringComparison.OrdinalIgnoreCase))
_dumpType = HangDumpCommandLineProvider.MapToSupportedDumpType(requested);
if (!string.Equals(_dumpType, requested, StringComparison.OrdinalIgnoreCase))
{
await _outputDisplay.DisplayAsync(
new FormattedTextOutputDeviceData(string.Format(CultureInfo.InvariantCulture, ExtensionResources.HangDumpTypeIfSupportedFallbackInfoMessage, requested, mapped)),
new FormattedTextOutputDeviceData(string.Format(CultureInfo.InvariantCulture, ExtensionResources.HangDumpTypeIfSupportedFallbackInfoMessage, requested, _dumpType)),
cancellationToken).ConfigureAwait(false);
}
}
Expand Down
Loading