[Lean Squad] feat(fv): Task 6 — Lean–C# correspondence review for primary targets - #7860
Merged
Evangelink merged 1 commit intoApr 27, 2026
Conversation
…ryUnescape, and TreeNodeFilter Document how each Lean 4 model maps to the C# source for the three primary FV targets: - ArgumentArity: structure mapping, Int approximation, Int32.MaxValue sentinel, DecidableEq, excluded GetHashCode/object.Equals, theorem correspondence table - CommandLineParser.TryUnescape: signature simplification (IEnvironment→newLine, option dropped, out params→Except), sequential Replace order, bug edge cases treated as unreachable in spec - TreeNodeFilter.MatchFilterPattern: FilterExpression hierarchy → inductive type, Regex abstracted to String→Bool, PropertyBag abstracted, Boolean-algebra theorems Also document general C#→Lean conventions for the project. 🔬 Lean Squad — automated FV correspondence review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds detailed Lean 4 ↔ C# correspondence documentation for the three primary formal-verification targets (ArgumentArity, CommandLineParser.TryUnescape, TreeNodeFilter.MatchFilterPattern), plus a set of general modelling conventions to standardize future specs.
Changes:
- Documented C#→Lean construct mappings, deliberate approximations, exclusions, and open questions for
ArgumentArity. - Documented a simplified Lean-facing spec signature and behavioural notes for
CommandLineParser.TryUnescape, including the sequential escape replacement model. - Outlined a planned inductive Lean model for
TreeNodeFilter.MatchFilterPatternand enumerated intended Boolean-algebra theorems.
Show a summary per file
| File | Description |
|---|---|
| formal-verification/CORRESPONDENCE.md | Adds correspondence mappings and modelling conventions for the three primary FV targets. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
YuliiaKovalova
approved these changes
Apr 27, 2026
Evangelink
deleted the
lean-squad/task6-correspondence-2026-04-26-a8bd16435dd5deb9
branch
April 27, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document how each Lean 4 model maps to the C# source for the three primary FV targets:
Also document general C#→Lean conventions for the project.
🔬 Lean Squad — automated FV correspondence review.
Fixes #7851