Skip to content

Restore localization filters after #10268 - #10281

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/fix-pr10268-localization
Jul 28, 2026
Merged

Restore localization filters after #10268#10281
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/fix-pr10268-localization

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Follow-up to #10268. A late OneLocBuild commit landed after the filtered head was approved and reintroduced invalid translations in 10 files. This restores those reviewed resource units to their pre-merge values.

Remove invalid translations reintroduced by a late OneLocBuild commit after the filtered PR had already been approved.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c475df24-a912-49c8-8f59-18524c91af55
Copilot AI review requested due to automatic review settings July 28, 2026 07:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores localization units overwritten by late OneLocBuild commits after #10268’s review.

Changes:

  • Restores nine invalid translations to English fallback with state="new".
  • Removes an extraneous {0} placeholder from the French analyzer text.
Show a summary per file
File Description
CrashDumpResources.fr.xlf Restores crash-sequence fallback text.
Resources.zh-Hant.xlf Restores ResourceLock description fallback.
Resources.ru.xlf Restores ResourceLock description fallback.
Resources.ja.xlf Restores Native AOT description fallback.
Resources.fr.xlf Removes an invalid placeholder.
Resources.es.xlf Restores ResourceLock message fallback.
Resources.de.xlf Restores ResourceLock description fallback.
Resource.de.xlf Restores cleanup cancellation fallback.
PlatformAdapterResources.ko.xlf Restores browser runsettings fallback.
PlatformAdapterResources.de.xlf Restores browser runsettings fallback.

Review details

  • Files reviewed: 10/10 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Verdict: ✅ All clear — no issues found.

This PR reverts invalid OneLocBuild translations that landed after #10268 was approved, resetting affected <target> elements to state="new" with the English source text. The changes are mechanical and correct:

  • All 10 .xlf files consistently reset state="translated"state="new" with the English source as placeholder.
  • The XML prolog BOM/whitespace fix (<?xml version="1.0" encoding="utf-8"?>) is consistently applied.
  • The Resources.fr.xlf fix removes a stray {0} placeholder that was incorrectly present in the French translation.

No public API, logic, or behavioral changes. No concerns across any of the 22 review dimensions.

@Evangelink
Evangelink merged commit 396b133 into main Jul 28, 2026
15 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/fix-pr10268-localization branch July 28, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants