Fix MSTEST0063 to detect invalid constructors on derived TestClass attributes by @Evangelink in #9851 (backport to rel/4.3) - #10115
Merged
Evangelink merged 1 commit intoJul 21, 2026
Conversation
…tributes TestClassConstructorShouldBeValidAnalyzer used an exact-match check (SymbolEqualityComparer.Default.Equals) for TestClassAttribute, so derived attributes like [STATestClass] or custom [MyTestClass] were silently skipped. MSTest discovers such classes at runtime via Inherits() logic, so a private/internal constructor causes a runtime failure but no analyzer warning. Switch the guard to IsTestClass() (which uses Inherits()) to match the runtime discovery logic, and add four tests covering derived and custom TestClass attributes. Fixes microsoft#9836 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1590213-39c9-4b3d-9fa4-1d10ac4961cc
Evangelink
approved these changes
Jul 21, 2026
Evangelink
enabled auto-merge (squash)
July 21, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9851 to rel/4.3
/cc @Evangelink