Skip to content

Just a heads up that 4.3.0 broke my build #9756

Description

@SimonCropp

given it transitively forces a System.ValueTuple v4.6.2

C:\projects\verify\src\Verify.MSTest.Tests\Verify.MSTest.Tests.csproj : error NU1109: Detected package downgrade: System.ValueTuple from 4.6.2 to centrally defined 4.5.0. Update the centrally managed package version to a higher version.  [C:\projects\verify\src\Verify.slnx]
C:\projects\verify\src\Verify.MSTest.Tests\Verify.MSTest.Tests.csproj : error NU1109:  Verify.MSTest.Tests -> MSTest 4.3.0 -> Microsoft.Testing.Extensions.CodeCoverage 18.9.0 -> System.Text.Json 10.0.8 -> System.ValueTuple (>= 4.6.2)  [C:\projects\verify\src\Verify.slnx]
C:\projects\verify\src\Verify.MSTest.Tests\Verify.MSTest.Tests.csproj : error NU1109:  Verify.MSTest.Tests -> System.ValueTuple (>= 4.5.0) [C:\projects\verify\src\Verify.slnx]
C:\projects\verify\src\Verify.MSTest.DisableAttachments.Tests\Verify.MSTest.DisableAttachments.Tests.csproj : error NU1109: Detected package downgrade: System.ValueTuple from 4.6.2 to centrally defined 4.5.0. Update the centrally managed package version to a higher version.  [C:\projects\verify\src\Verify.slnx]
C:\projects\verify\src\Verify.MSTest.DisableAttachments.Tests\Verify.MSTest.DisableAttachments.Tests.csproj : error NU1109:  Verify.MSTest.DisableAttachments.Tests -> MSTest 4.3.0 -> Microsoft.Testing.Extensions.CodeCoverage 18.9.0 -> System.Text.Json 10.0.8 -> System.ValueTuple (>= 4.6.2)  [C:\projects\verify\src\Verify.slnx]
C:\projects\verify\src\Verify.MSTest.DisableAttachments.Tests\Verify.MSTest.DisableAttachments.Tests.csproj : error NU1109:  Verify.MSTest.DisableAttachments.Tests -> System.ValueTuple (>= 4.5.0) [C:\projects\verify\src\Verify.slnx]
    0 Warning(s)
    2 Error(s)
Time Elapsed 00:01:12.44

while for back compat i use 4.5.0.

it is a pretty well known issue with System.ValueTuple https://github.com/dotnet/maintenance-packages/issues?q=is%3Aissue%20state%3Aopen%20System.ValueTuple

and the usual fix is to pin to 4.5.0 and let the top level consumer decide if they want a newer version

from my perspective, if you want to force a newer System.ValueTuple, then consider dropping support for older frameworks that it does not play well with

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions