[api-extractor] add basic support for import * as module from './local-module'#1796
[api-extractor] add basic support for import * as module from './local-module'#1796octogonz merged 39 commits intomicrosoft:masterfrom
import * as module from './local-module'#1796Conversation
import * as module from './local-module'import * as module from './local-module'
|
Saw that it was a build failure and got more details by running the regular gulp script in the |
@stevengum awesome feedback! Thanks for doing the review. Have made the updates and pushed the changes. I have not added any tests but please give me some directions on how I can write some tests and I am happy to add that as well. |
|
@mckn sorry for the delay, I'm not a regular contributor to this project so I don't know how to write/run tests. I've pulled the grafana branch and was going to run the tests locally, it looks like they've already passed as part of the setup of the repo. I don't have insight into their CI pipelines either, could the |
|
@stevengum I have added one some simple tests to verify the |
|
@octogonz would be awesome if you could have a look at this PR 🙏 |
|
|
|
Disregard that comment. After a clean build of my documentation it seems to be working fine. |
|
I will add that this does fix the underlying issue for me. I've been using a local patch to work around this for my documentation builds and that patch is no longer necessary. |
|
Happy to see there's a PR already in this advanced stage for this. This is a must to support api-extractor for Angular projects as well, as there's limited control on the typings output from the CLI |
|
@octogonz any updates here? |
To be clear, what's blocking this PR wasn't the code review, but rather some nontrivial work required to complete the implementation. (Some of which is identified by |
…mespaceImport members get analyzed similar to exported APIs
|
Today I got the |
|
🚀 This is finally ready to go! I tested it by building a large production monorepo with lots of projects that use API Extractor. |
|
Released with API Extractor 7.17.0 |
microsoft#1796 (comment) # Conflicts: # apps/api-extractor/src/analyzer/AstSymbolTable.ts # apps/api-extractor/src/analyzer/ExportAnalyzer.ts # apps/api-extractor/src/collector/Collector.ts # apps/api-extractor/src/generators/ApiModelGenerator.ts
I have basically taken the PR created by @adventure-yunfei here
and cleaned up the code a bit. Tested it on the Grafana project which is a really big project and then opened this PR.
Thanks and great work by @adventure-yunfei!
Please let me know what you want to be adressed to get it merged. I think there are several people that wants to help out to get this PR merged.
Fixes: #1029