Making gesture views accessibile#196
Conversation
…asen/gestureview_accessibility
…esture views. Also make gesture views accessible by default as it generally always has actions that can be perfomed on them by the users. and hence needs to b exposed to screen readers as well
|
@RamyaSenk, |
erictraut
left a comment
erictraut
left a comment
There was a problem hiding this comment.
Please update the "accessibility.md" documentation to indicate that GestureView (in addition to View, Button and TextInput) supports the common accessibility props.
Is there anything that needs to be done on the web implementation of GestureView?
src/native-common/GestureView.tsx
Outdated
| return ( | ||
| <RN.View | ||
| style={ this._getStyles(this.props) } | ||
| style={this._getStyles(this.props)} |
There was a problem hiding this comment.
Please add spaces within the curly brackets to be consistent with all other code in ReactXP.
There was a problem hiding this comment.
Done. Updated it.
|
Thanks @erictraut I have updated the document and fixed spaces. I missed web, have implemented accessibility props in there as well. |
* Makign Gesture view accessibility property to true * Exposing accessibility property in gesture view * Making gesture Views accessibile. Expose the accessibility props in gesture views. Also make gesture views accessible by default as it generally always has actions that can be perfomed on them by the users. and hence needs to b exposed to screen readers as well * Removing gesture dist file * Updating documentation
3 participants
Currently we cannot recognise swipe and pan gestures when screen reader is enabled. Making gesture views implement accessibility properties. Also making gesture views accessible by default because it is associated with actions done on the view - which should almost always be accessible. Similar to button behaviour.
You can test these gestures by long pressing on the gesture view and performing the gesture like swipe and pan.