fix(socks): handle IPv4-mapped IPv6 addresses in ipToSocksAddress#41110
Merged
Conversation
On dual-stack systems Node.js returns IPv4-mapped IPv6 addresses (e.g. "::ffff:10.0.0.1") from socket.localAddress. These fail net.isIPv4() and fell into the IPv6 branch, producing a malformed SOCKS address. Unwrap the ::ffff: prefix to a plain IPv4 dotted-quad before the isIPv4 check. Fixes: microsoft#41107
pavelfeldman
approved these changes
Jun 2, 2026
Contributor
Test results for "MCP"1 failed 7229 passed, 1103 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 flaky39528 passed, 775 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket.localAddressreturns IPv4-mapped IPv6 addresses (e.g.::ffff:10.0.0.1) on dual-stack systems, which failnet.isIPv4()and fell into the IPv6 branch ofipToSocksAddress, producing a malformed SOCKS address.::ffff:prefix to a plain IPv4 dotted-quad before theisIPv4check.Fixes #41107