Skip to content

fix(trace-viewer): keep selected action in view after "Show all"#40809

Merged
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-40808
May 13, 2026
Merged

fix(trace-viewer): keep selected action in view after "Show all"#40809
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-40808

Conversation

@yury-s

@yury-s yury-s commented May 12, 2026

Copy link
Copy Markdown
Member

Summary

  • When the action list time filter is cleared via Show all, scroll the previously selected action back into view instead of jumping to the top of the unfiltered list.
  • Adds a small revealSelectedKey trigger on TreeView; ActionList bumps it on Show all.

Fixes #40808

When a time filter is active in the trace viewer action list (set by
double-clicking an action), clicking "Show all" cleared the filter but
scroll-jumped the list to the top, losing the user's place when the
selected action was deep in the list.

Now TreeView accepts a `revealSelectedKey` trigger; ActionList bumps it
on "Show all" so the selected item is scrolled back into view in the
unfiltered list.

Fixes microsoft#40808
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/pdf.spec.ts:58 › save as pdf (filename: output.pdf) @mcp-macos-latest-chromium

7069 passed, 1068 skipped


Merge workflow run.

@yury-s yury-s merged commit 62d1ea1 into microsoft:main May 13, 2026
42 of 44 checks passed
@yury-s yury-s deleted the fix-40808 branch May 13, 2026 00:19
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [firefox-page] › page/workers.spec.ts:177 › should clear upon cross-process navigation `@firefox-ubuntu-22.04-node20`

41707 passed, 846 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Trace Viewer UX Improvement - preserve and restore scroll position when returning to Actions List via "Show all"

2 participants