feat(network): add request and requestFinished events to APIRequestContext#34938
feat(network): add request and requestFinished events to APIRequestContext#34938shahzad31 wants to merge 8 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
@microsoft-github-policy-service agree company="Elastic" |
This comment has been minimized.
This comment has been minimized.
|
Hi, @dgozman can you please take a look, i see you have review similar PR like this in the past. I would appreciate some feedback before i spent bit more time on figuring out why build is failing :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Shahzad <shahzad31comp@gmail.com>
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"8 failed 3 flaky38659 passed, 793 skipped Merge workflow run. |
|
Please wait for the supporting signal on the issue prior to sending the PRs! |
Playwright's APIResponse doesn't expose securityDetails(), serverAddr(), or request/response timings (upstream microsoft/playwright#32647 and microsoft/playwright#34938 were both declined; see microsoft/playwright#40905 for the current ask). To still surface this for HTTPS API monitoring use cases (cert expiry, remote-address alerting, response size tracking), open a side-channel tls.connect() in parallel with each request and fold the result into the NetworkInfo entry: - securityDetails: issuer, subjectName, protocol, validFrom, validTo - remoteIPAddress / remotePort - coarse dns / connect / ssl timings Probes are cached per host:port within a journey and silently skipped for HTTP or on failure (timeout, refused, untrusted) so they never affect the actual request. Also derive request and response body bytes (Content-Length preferred, buffer fallback) and emit server.ip / server.port in the JSON reporter. Co-authored-by: Cursor <cursoragent@cursor.com>
Playwright's APIResponse doesn't expose securityDetails(), serverAddr(), or request/response timings (upstream microsoft/playwright#32647 and microsoft/playwright#34938 were both declined; see microsoft/playwright#40905 for the current ask). To still surface this for HTTPS API monitoring use cases (cert expiry, remote-address alerting, response size tracking), open a side-channel tls.connect() in parallel with each request and fold the result into the NetworkInfo entry: - securityDetails: issuer, subjectName, protocol, validFrom, validTo - remoteIPAddress / remotePort - coarse dns / connect / ssl timings Probes are cached per host:port within a journey and silently skipped for HTTP or on failure (timeout, refused, untrusted) so they never affect the actual request. Also derive request and response body bytes (Content-Length preferred, buffer fallback) and emit server.ip / server.port in the JSON reporter. Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes #34924 !!
Added request and requestFinished events to APIRequestContext
Usage