cft download location change requests all mirrors update their locations

[JounQin]

I'm using custom PLAYWRIGHT_DOWNLOAD_HOST: https://cdn.npmmirror.com/binaries/playwright and PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST: https://cdn.npmmirror.com/binaries/chrome-for-testing envs.

For example:

https://cdn.npmmirror.com/binaries/chrome-for-testing/145.0.7632.6/mac-arm64/chrome-mac-arm64.zip (OK)

vs

https://cdn.npmmirror.com/binaries/chrome-for-testing/builds/cft/145.0.7632.6/mac-arm64/chrome-mac-arm64.zip (404)

---

See also cnpm/cnpmcore#965 (comment)

Originally posted by @JounQin in #39037 (comment)

[yury-s]

There was a fix in 1.58.1 that unified CfT download url with others (see this issue #38967). Is it still a problem for you on the latest Playwright? If so, can you explain in more details what you are trying to do and what is not working?

[JounQin]

@yury-s I'm using a 3rd-party mirror of playwright and chrome-for-testing with PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST env, as the PR description, before the CfT download url change, the 3rd-party url should be https://cdn.npmmirror.com/binaries/chrome-for-testing/145.0.7632.6/mac-arm64/chrome-mac-arm64.zip which works fine, but after that change, the requested url becomes to https://cdn.npmmirror.com/binaries/chrome-for-testing/builds/cft/145.0.7632.6/mac-arm64/chrome-mac-arm64.zip because builds/cft is hard coded at

playwright/packages/playwright-core/src/server/registry/index.ts

Lines 130 to 139 in a73cb2c

	function cftUrl(suffix: string): DownloadPathFunction {
	return ({ browserVersion }) => {
	return {
	path: `builds/cft/${browserVersion}/${suffix}`,
	mirrors: [
	'https://cdn.playwright.dev',
	],
	};
	};
	}

what means it requests 3rd-party mirrors use builds/cft at the same time.

[yury-s]

Closing as this is a problem with https://cdn.npmmirror.com. If you want to report an issue with Playwright, please file a new report and follow the bug template to provide exact repro steps, e.g. which exact npx playwright install command worked before and now doesn't.

[JounQin]

Closing as this is a problem with cdn.npmmirror.com. If you want to report an issue with Playwright, please file a new report and follow the bug template to provide exact repro steps, e.g. which exact npx playwright install command worked before and now doesn't.

@yury-s

Why it's a problem with https://cdn.npmmirror.com? The builds/cft part is added by #39037, before that PR, 3rd-party mirrors are using no builds/cft paths which work, after that PR, builds/cft is required to be added into 3rd-party mirrors paths. Is that really expected?

I think builds/cft should only be required for official mirrors?

cc @elrrrrrrr @fengmk2

[fengmk2]

@JounQin You can submit a PR to playwright to fix this logic, making the builds/cft path an option or overriding it through an environment variable.

[JounQin]

@JounQin You can submit a PR to playwright to fix this logic, making the builds/cft path an option or overriding it through an environment variable.

Thanks, I'll wait @yury-s for an accepted solution first before PR.

[JounQin]

Friendly ping @yury-s