feat: pytest-playwright-asyncio as separate plugin#257
Merged
Conversation
mxschmitt
force-pushed
the
async-plugin-separate-package
branch
2 times, most recently
from
ec57569 to
cd9d583
Compare
mxschmitt
changed the title
mxschmitt
changed the title
mxschmitt
force-pushed
the
async-plugin-separate-package
branch
2 times, most recently
from
41864d8 to
cc1f672
Compare
mxschmitt
force-pushed
the
async-plugin-separate-package
branch
5 times, most recently
from
a8e4767 to
b49d730
Compare
yury-s
approved these changes
Nov 13, 2024
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
lgtm provided there is an
- easy way to run both sync and async in same project
- we extract common bits from the two implementations into a shared file
mxschmitt
force-pushed
the
async-plugin-separate-package
branch
3 times, most recently
from
a82be11 to
64fa648
Compare
mxschmitt
force-pushed
the
async-plugin-separate-package
branch
from
64fa648 to
f7aeadd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #184 just as a separate plugin. The main reason for this is that Pylance, the Python language server for VSCode does automatically look for Pytest plugins in order to provide fixture autocompletion. This isn't possible when we dynamically register the plugins, since it just looks at the AST.
If a user wants to partially migrate from sync to async or vice-versa, the user can run Pytest twice, one time with
-p no:playwrightand one time withno:playwright-asyncio.Pretty-diff between async fixtures and sync fixtures: eb6c55a
Closes #184
Relates #74