Conversation
mxschmitt
force-pushed
the
add-py.typed
branch
from
b08cfbf to
78d836a
Compare
dgozman
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
py.typedfile to tellmypy(a Python linter) that we are a typed package.Before we didn't treat
playwright-pytest/pytest_playwright/pytest_playwright.py
Line 271 in 695c3ea
new_contextfunction which is reasonable.Is the name
CreateContextCallbackappropriate? We are still under0.Xreleases - so we could rename in theory.Fixes #244