You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@wptestyyh I noticed that v0.5.2 was already published. Are you going to delete that and re-do the release after this is merged?
nope, I don't plan to redo it. I publish it, validate the ingestion works on windows, then create this PR to merge the 0.5.2 version tag back to develop branch. Since I didn't see anything is wrong, I will keep it. Let me know if anything is wrong.
@wptestyyh I noticed that v0.5.2 was already published. Are you going to delete that and re-do the release after this is merged?
nope, I don't plan to redo it. I publish it, validate the ingestion works on windows, then create this PR to merge the 0.5.2 version tag back to develop branch. Since I didn't see anything is wrong, I will keep it. Let me know if anything is wrong.
Sorry, I missed this was merging the release branch into develop. All good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Publish 0.5.2
Technical Details
None
Test Results
Build succeeds
Reviewer Focus
None
Future Work
None
Checklist
allcompiles cleanly.