Skip to content

Implement AeroflexWeinschle83XX attenuator library#341

Merged
wptestyyh merged 4 commits into
developfrom
socketattlib
Apr 18, 2025
Merged

Implement AeroflexWeinschle83XX attenuator library#341
wptestyyh merged 4 commits into
developfrom
socketattlib

Conversation

@wptestyyh
Copy link
Copy Markdown
Member

@wptestyyh wptestyyh commented Apr 16, 2025

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Enable controlling AeroflexWeinschle83XX by socket

Technical Details

  • Add RfAttenuatorAeroflexWeinschle83XXFactory to create AeroflexWeinschle83XX attenuator controller
  • Add RfAttenuatorTransportSocketLinux to communicate with attenuator by socket
  • Add SocketHelpers to connect, send and receive data to/from the attenuator
  • Add some utility classs

Test Results

  • A test tool will be added and run latter in next PR

Reviewer Focus

  • None

Future Work

  • A test tool calls those API exposed by this library to control AeroflexWeinschle83XX attenuator
  • Need move /home/test/netremote/src/common/rfattenuator out of common folder to /home/test/netremote/src/linux, and change the grpc service code to use rfattenuator interface instead of directly create its instance in the grpc service. So, the common folder can still be platform independent and can build on both linux and windows

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@wptestyyh wptestyyh requested a review from a team as a code owner April 16, 2025 04:23
Comment thread src/common/rfattenuator/lib/RfAttenuatorTransport.hxx Outdated
Comment thread src/common/rfattenuator/lib/RfAttenuatorTransport.hxx Outdated
Comment thread src/common/rfattenuator/lib/RfAttenuatorTransportSocketLinux.cxx Outdated
Comment thread src/common/rfattenuator/lib/RfAttenuatorTransportSocketLinux.cxx Outdated
Comment thread src/common/rfattenuator/lib/RfAttenuatorTransportSocketLinux.hxx Outdated
Comment thread src/common/rfattenuator/lib/RfAttenuatorTransportSocketLinux.hxx Outdated
Comment thread src/common/rfattenuator/lib/SocketHelpers.cxx Outdated
Comment thread src/common/rfattenuator/lib/SocketHelpers.hxx Outdated
@wptestyyh wptestyyh merged commit 75179c4 into develop Apr 18, 2025
3 of 5 checks passed
@wptestyyh wptestyyh deleted the socketattlib branch April 18, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants