Skip to content

Allow specifying JSON configuration to netremote-server on command-line#329

Merged
abeltrano merged 12 commits into
developfrom
serverapattrs
Jul 30, 2024
Merged

Allow specifying JSON configuration to netremote-server on command-line#329
abeltrano merged 12 commits into
developfrom
serverapattrs

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow specifying fixed/static configuration via a JSON file.
  • Allow associating RF attenuator channel configuration with access points and make such information available at runtime.

Technical Details

  • Expose ability to look up AccessPointAttributes from AccessPointManager.
  • Consolidate IAccessPointFactory::Create() functions into one.
  • Pass AccessPointAttributes from IAccessPointCreateArgs to concrete IAccessPoint constructor upon creation.
  • Add string <-> string property map to AccessPointAttributes to allow association of unstructured data to access point.
  • Add helper to parse JSON configuration file contents (NetRemoteServerJsonConfiguration).
  • Add netremote-server CLI flag -c (--config, etc.) to specify optional JSON configuration file location.
  • Expand NetRemoteServerConfiguration with access point attributes parsed from JSON configuration file, if specified.
  • Extend AccessPointDiscoveryAgentOperationsNetlink to accept function to look up access point attributes, and if available, pass them to the IAccessPointFactory instance so they are forwarded to the created IAccessPoint insteance.
  • Add related unit tests.
  • Fix a few typos in code surrounding that which was modified.

Test Results

  • All unit tests pass on both Windows and Linux.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 29, 2024 22:58
@abeltrano abeltrano merged commit bf81dee into develop Jul 30, 2024
@abeltrano abeltrano deleted the serverapattrs branch July 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant