Skip to content

Fix regression in abseil dependency#314

Merged
abeltrano merged 2 commits into
developfrom
debugcicd
Jul 16, 2024
Merged

Fix regression in abseil dependency#314
abeltrano merged 2 commits into
developfrom
debugcicd

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the GitHub CI/CD build succeeds.

Technical Details

The most recent version(s) of abseil, depended on by grpc and protobuf, introduced a regression where changes to its tests caused gtest became a hard dependency without adding corresponding CMake changes to locate the library.

  • Fix this by adding a vcpkg overlay port for abseil, and modify the latest version to include a manually written patch that makes the erroneous test target a test-only target.

Test Results

  • GitHub build validation CI/CD workflow now passes.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 16, 2024 19:53
@abeltrano abeltrano merged commit e2f18cb into develop Jul 16, 2024
@abeltrano abeltrano deleted the debugcicd branch July 16, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant