Skip to content

Enable use of Ieee80211FrequencyBand literals _MHz and _GHz on Windows with MSVC#300

Merged
abeltrano merged 3 commits into
developfrom
fixfreqliterals
Jun 28, 2024
Merged

Enable use of Ieee80211FrequencyBand literals _MHz and _GHz on Windows with MSVC#300
abeltrano merged 3 commits into
developfrom
fixfreqliterals

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

Technical Details

  • Drop the literal definitions from constexpr to const.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • It'd be nice to restore this to constexpr.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner June 28, 2024 21:40
@abeltrano abeltrano merged commit c4ed2bd into develop Jun 28, 2024
@abeltrano abeltrano deleted the fixfreqliterals branch July 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow _GHz operator use on Windows

1 participant