Skip to content

Expose access point mac address from NetworkInterfacesEnumerate API#280

Merged
abeltrano merged 4 commits into
developfrom
enummac
May 28, 2024
Merged

Expose access point mac address from NetworkInterfacesEnumerate API#280
abeltrano merged 4 commits into
developfrom
enummac

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure API clients can uniquely identify an access point using its MAC address.

Technical Details

  • Plumb the mac address throughout the Wi-Fi portion of the stack, from Hostapd up to the protobuf API.

Test Results

  • All unit tests pass.
  • netremote-cli wifi aps shows the mac address of each result per below:
image

Reviewer Focus

  • Consider whether this is sufficient for test scenarios.

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner May 28, 2024 23:17
@abeltrano abeltrano merged commit 108783d into develop May 28, 2024
@abeltrano abeltrano deleted the enummac branch May 28, 2024 23:29
Copy link
Copy Markdown

@wiresharkyyh wiresharkyyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto message looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants