Skip to content

Differentiate bridge network interface type from others#277

Merged
abeltrano merged 1 commit into
developfrom
netmanenumifs
May 23, 2024
Merged

Differentiate bridge network interface type from others#277
abeltrano merged 1 commit into
developfrom
netmanenumifs

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure bridge interfaces are explicitly identified, instead of labeling them as Other.

Technical Details

  • Update the interface name checking code to explicitly check for "bridge" to map to bridge interfaces.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Possibly identify other interface types as well, including ethernet, but there is no current need.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner May 23, 2024 21:46
@abeltrano abeltrano changed the title Differentiate bridge network interface type from others. Differentiate bridge network interface type from others May 23, 2024
@abeltrano abeltrano merged commit 518bad6 into develop May 23, 2024
@abeltrano abeltrano deleted the netmanenumifs branch May 23, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant