Skip to content

Persist mDNS per-interface settings across reboots#270

Merged
abeltrano merged 2 commits into
developfrom
mdnsiffix
May 16, 2024
Merged

Persist mDNS per-interface settings across reboots#270
abeltrano merged 2 commits into
developfrom
mdnsiffix

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

@abeltrano abeltrano commented May 16, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure mDNS per-interface enablement persists across reboots.

Technical Details

  • Name per-interface drop-in instance directories to match the .network file names as this is a strict requirement. It's not enough to use the [Match] directive since the drop-in file itself won't be processed unless it has a basename prefix matching and existing .network file.
  • Add netplan- suffix to ensure drop-in instance directory basename matches that generated by netplan.
  • Rename some variables in the bash config script to be more accurate.

Test Results

  • Installed netremote-server-XXX.deb package, rebooted, then verified mDNS was enabled on all interfaces, per below status on the local test machine:
image

And a separate machine scanning for mDNS services showing the manually configured DNS-SD service netremote2._netremote._udp.local:

image

Reviewer Focus

  • None

Future Work

  • None (hopefully).

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner May 16, 2024 22:07
@abeltrano abeltrano changed the title Fix mDNS drop-in directory naming Persist mDNS per-interface settings across reboots May 16, 2024
@abeltrano abeltrano merged commit c75c2b2 into develop May 16, 2024
@abeltrano abeltrano deleted the mdnsiffix branch May 16, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant