Skip to content

Enable mDNS on each selected interface #267

Merged
abeltrano merged 2 commits into
developfrom
mdnspackaging
May 15, 2024
Merged

Enable mDNS on each selected interface #267
abeltrano merged 2 commits into
developfrom
mdnspackaging

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

Technical Details

  • Remove duplicate call to mdns_configure.
  • Invoke resolvectl mdns <interface> yes
  • Add newline in mDNS configuration prompt template.

Test Results

  • Tests from prior PR were actually performed with this version of the code.

Reviewer Focus

  • None

Future Work

  • Global mDNS setting still needs to be configured.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano marked this pull request as ready for review May 15, 2024 16:35
@abeltrano abeltrano requested a review from a team as a code owner May 15, 2024 16:35
@abeltrano abeltrano merged commit ef5de8a into develop May 15, 2024
@abeltrano abeltrano deleted the mdnspackaging branch May 15, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant