Skip to content

DataStreamDownload API improvements#187

Merged
corbin-phipps merged 6 commits into
feature/dataStreamingfrom
user/corbinphipps/download-api-improvements
Feb 29, 2024
Merged

DataStreamDownload API improvements#187
corbin-phipps merged 6 commits into
feature/dataStreamingfrom
user/corbinphipps/download-api-improvements

Conversation

@corbin-phipps
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

Address PR comments.

Technical Details

  • Simplify oneof field names in Properties.
  • Use const std::string& instead of const std::string.
  • Add class member for client reactor timeout values.
  • Re-order message fields so always present fields are first.
  • Allocate DataStreamReader on stack in test client code.

Test Results

All tests pass.

Reviewer Focus

None.

Future Work

None.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@corbin-phipps corbin-phipps requested a review from a team as a code owner February 29, 2024 01:30
@corbin-phipps corbin-phipps merged commit da6bc6b into feature/dataStreaming Feb 29, 2024
@corbin-phipps corbin-phipps deleted the user/corbinphipps/download-api-improvements branch February 29, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant