Fix crash on access point presence events#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
netremote-serverare handled correctly and do not cause a crash.Technical Details
Nl80211Interfaceparsing code for decoding nl80211 event info on presence change events.AccessPointCreateArgsLinuxargs when constructing access points in response to presence change events (this is the bug fix).Nl80211Interfacesuitable for use in unique containers.std::unordered_mapof utility structure withstd::unordered_set<Nl80211Interface>for the "seen" cache.Test Results
netremote-serverwas running and validated log output was expected:Reviewer Focus
Future Work
Checklist
allcompiles cleanly.